Fix initial modularity for walktrap #1974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1974 +/- ##
========================================
Coverage 74.94% 74.94%
========================================
Files 347 347
Lines 57893 57898 +5
========================================
+ Hits 43387 43394 +7
+ Misses 14506 14504 -2
Continue to review full report at Codecov.
|
szhorvat
approved these changes
Feb 23, 2022
|
My only comment is that it would be nice to backport this to 0.9 as well so it can go into the 1.3 R release... but if you think it's not important, just skip it. |
|
Yeah, I agree, I will backport to 0.9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Walktrap maintains a list of modularity along each step of its merging of various communities. The initial modularity was always incorrectly set to 0, instead of the modularity of the singleton partition. Walktrap returns the actual membership that contains the maximum modularity.
The actual partition that was identified in walktrap in #1927 is the partition that puts the whole graph into a single cluster, which has a modularity of 0. However, because the initial modularity before any merge was incorrectly set to 0, it incorrectly returned the singleton partition instead. This PR fixes #1927.