-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid quoting of libxml2 include path #1181
Comments
I suggest you do not do this. This was never explicitly supported and people using libraries from conda (more often accidentally than on purpose) was one of the main sources of trouble in the past. See for example: https://r.igraph.org/articles/installation-troubleshooting.html#libgfortran-so-4-cannot-open-shared-object-file-no-such-file-or-directory System libraries are stable, conda environment are too easy to change accidentally, or to deactivate. Of course the bad quoting is a real issue that needs to be fixed. |
@Antonov548 Why is the include directory cut from the |
To illustrate my point, this happened once again just today, see #1183 |
Good point. I will check. Thanks |
glad you will fix thanks! |
@tdhock Does your system have libxml2 development files? C/igraph bundles both GLPK and GMP, and it might become possible to use the bundled versions in the future in R/igraph as well. But it does not bundle libxml2. |
no libxml2 is not provided by the cluster (outside of conda)
|
How about |
only with conda
|
I got:
I'm using linux mint 21.2 |
Is this now fixed? |
I think should be fixed with #1197 |
this has been fixed using new version from github.
new command: (bad quotes are gone)
|
any ideas when this will appear on CRAN? |
Couldn't help but think of:
Earlier, if we're very lucky. |
How to solve this problem? In file included from vendor/cigraph/src/community/optimal_modularity.c:32:
my R.version: |
@peibana: Please install GLPK. For support requests, please use https://igraph.discourse.group/ in the future. Comments to existing closed issues may be overlooked too; for bug reports, please open a new issue and link to existing issues if applicable. |
What happens?
Hi! I am trying to install igraph R package, using system libraries installed to a conda environment. I thought that should be possible since it worked fine with previous versions of igraph. It seems the update yesterday changed something, which causes Makevars to now look like this on my system:
So
@cflags@
is expanded to-I"/home/th798/.conda/envs/igraph/include/libxml2 -I/home/th798/.conda/envs/igraph/include"
which is problematic because inside the double quotes is another -I flag. The fix should be to properly quote the -I flags if necessary, otherwise in my case at least, just deleting the double quotes from the generated gcc/g++ lines allows compilation to proceed normally. See tdhock/data.table-revdeps#16 (comment) for full details/installation output.To Reproduce
To reproduce, do create a new conda env, conda install gmp glpk libxml2, then install.packages("igraph"), on my system I get the output below:
The text was updated successfully, but these errors were encountered: