-
-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: configure
manage libxml multiple include paths
#1197
Conversation
Current Aviator status
This PR was merged using Aviator.
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good. I wonder if sed -r
would give cleaner regular expressions. Is it worth renaming the xml2_include_dir
variable?
Why do we need to keep the Removing the fragile |
As I remember the problem is that |
Also, to be completely robust, don't we need to add the output of |
Are you sure? Do we have an example of this? If yes, there should be a comment about this in the |
I think we had an issue. I will try to find... |
I just attempted to install libxml2 into a directory with spaces in the path, and the |
This is pull request in which I have added quotes. #1000 The problem was on Windows. But then I remember I also tried to make this trick on Ubuntu which you did and decided to add sanity check for Ubuntu as well. |
If the problem was quoted paths with spaces, then wouldn't the regex |
Oh, yes, You are right. |
Given that the bug is in We should tell people not to install RTools in Opinion, @krlmlr ? |
I mean, do we parse up to the next This is why I'm suggesting NOT to fix this, as it's not possible to create a robust fix on our end. After all there's an easy workaround: Install RTools to a safe location, without weird characters in the path. |
For safety, it'd be good to check what the default installation location is for RTools. If that is not in Program Files then we're good. |
I'm agree to leave as it is, I mean just what |
The RTools installation instructions have this:
We have a strong case. We could just add a troubleshooting entry about this for people who chose to install to a different location. Most people don't compile on Windows anyway, so the impact is small. |
This script isn't run on Windows, AFAICT. Windows runs only No strong opinion. Can we somehow fix upstream in |
Then this workaround isn't needed at all—let's remove it completely.
If |
Can we please rename Shall we fix the link flags ( |
@krlmlr It looks like fixing all of The next most impactful fix would be making dependencies optional again, #1156, but that is a lot more work so let's maybe not wait for it before other essential fixes go out ... |
Thanks! Opening a follow-up issue to handle Szabolcs's feedback |
559a2db
to
f751ddf
Compare
Closes #1190