This repository has been archived by the owner on May 12, 2021. It is now read-only.
この間のアレにspec追加しました。 #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's shorter I forgot to define some_other_object, but I don't want to increase the lines, so choose Module, which doesn't need to be initialized by let
| end | ||
| it 'remembers to do the important thing!' do | ||
| expect(SomeModule).to receive(:some_important_method) | ||
| subject.some_subject_method |
There was a problem hiding this comment.
beforeブロックのsubject.some_subject_methodと完全にダブってます。
これだけ単純なメソッド呼び出しだから気にならないかもしれませんが、
引数が多かったり、もっと複雑な場合でもこのように書きますか？
There was a problem hiding this comment.
それに、やっぱり他のexampleと違って、
expectationを先に書くのが
なんだかあまりしっくりきませんねぇ。 😕
「対象のメソッドを呼んだ後に〇〇な影響を起こす」
という観点で書くほうが自然じゃありませんか？
Closed
|
業務連絡：Ruby Hiroba終わったのでcloseします。 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
先輩、ようやくRSpecの使い方わかってきたので、
この間作った
GreatClassのspec書きました！ 😇後々になってしまってすみません！ 💦
※このPull Requestはフィクションです。実在のgem、エンジニア、アプリケーションなどとは一切関係ありません（ただし、crispy自体を除く）。
※私igrepによく似た後輩がPull Requestを送った、という頭のおかしい設定ですが、ご容赦ください。
※また、specを追加したのにビルドが落ちているのはご愛嬌です。
2014年9月21日 RubyHiroba編