Add speed controler for <audio> - Step 1 #175
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add speed controler for <audio> igrigorik#158 NOT FULLY TESTED Also need more work about controller
igrigorik
reviewed
Feb 5, 2017
| @@ -323,6 +323,12 @@ chrome.extension.sendMessage({}, function(response) { | |||
| } | |||
| }); | |||
| } | |||
| function getArrayFromTag(tagname) { | |||
There was a problem hiding this comment.
We can just used querySelector, no need for the extra gymnastics.
That said, handling audio requires a much deeper rethink of how the plugin works and how the speed is displayed and where. I don't think we should be landing this half-baked.. as it opens up a deep well of technical debt.
|
Closing, as this is a partial solution that would open up a lot of technical debt.. If/when we want to tackle audio as a first-class use case, we can revisit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add speed controler for #158
NOT FULLY TESTED
Also need more work about controller