Update our speed setting when the speed is changed externally. #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e.g. Coursera videos have their own speed controls. If the speed is changed from A to B via their controls, then the video is paused & resumed, our play callback would reset the speed to A. We now ensure our speed setting is accurate by updating it in the ratechange callback, which happens no matter how the speed is updated.
|
Hmm, this is counter to: 2e7308c - the ratechange logic was causing issues with some other players (if memory serves, Khan Academy..). |
In this state, the playback rate is always 1, as we haven't had a chance to update it yet (which currently happens in the play callback). Fixes speed setting when jumping between YouTube videos.
|
@igrigorik Interesting. This second change seems to fix the issue for me on YouTube/KA, and feels like a cleaner solution. |
|
@oggy hmm, can't reproduce the earlier error.. which is good news. Merging, thanks! |
igrigorik
added a commit
that referenced
this pull request
Jun 2, 2015
Update our speed setting when the speed is changed externally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g. Coursera videos have their own speed controls. If the speed
is changed from A to B via their controls, then the video is
paused & resumed, our play callback would reset the speed to A.
We now ensure our speed setting is accurate by updating it in the
ratechange callback, which happens no matter how the speed is
updated.