Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Missing/black chromosome name in batch mode using MATE_CHROMOSOME grouping since 2.12.0 #1172

Closed
cbrueffer opened this issue Jul 13, 2022 · 5 comments

Comments

@cbrueffer
Copy link

cbrueffer commented Jul 13, 2022

First of all, thanks for all your work on this software!

Working version: up to and including 2.11.9
Broken version: from 2.12.0 to latest (2.13.2 as of now)

I'm using IGV in batch mode and headless using xvfb-run with option SAM.GROUP_OPTION=MATE_CHROMOSOME. This should show the chromosome name in each "read group" in the top-left corner of each grouping. In batch mode this worked up to and including version 2.11.9. Since version 2.12.0, including the latest 2.13.2, only a black box is being printed.

Environment:

  • IGV installed via Bioconda
  • OpenJDK 11.0.15

The first (working) screenshot is from 2.11.9, the second (broken) from 2.12.0. Config, batch file etc are the same.
SV-2 11 9-working

SV-2 12 0-broken

@cbrueffer cbrueffer changed the title Missing/black chromosome name in batch mode using MATE_CHROMOSOME grouping since 2.12.0 Regression: Missing/black chromosome name in batch mode using MATE_CHROMOSOME grouping since 2.12.0 Jul 13, 2022
@jrobinso
Copy link
Contributor

Could you provide a test script, it's o.k. if the bam file isn't reachable I'll substitute another.

@jrobinso
Copy link
Contributor

@cbrueffer ignore test request, I can reproduce it.

Tangentially, I don't recall why we paint group labels (chromosome names in this case) with black background / white text, I think they should look as they do on screen.

@cbrueffer
Copy link
Author

Glad to hear it, I was just putting the files together.

I was wondering the same, at first I thought it was an Xvfb artifact.

@jrobinso
Copy link
Contributor

I tracked it down, its a java idiosyncrasy, found this in the java docs. I have switched from using "clearRect" to "fillRect" which seems to fix the problem. Fix will be in the next release, early August, and in the development snapshot within the next few minutes.

Beginning with Java 1.1, the background color of offscreen images may be system dependent. Applications should use setColor followed by fillRect to ensure that an offscreen image is cleared to a specific color

@cbrueffer
Copy link
Author

Thanks a lot for the quick fix!

jrobinso added a commit that referenced this issue Aug 11, 2022
…nment track group labels. Now uses white background - black text to match onscreen appearance. Fixes #1172
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants