Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix append #43

Merged
merged 4 commits into from
Mar 19, 2021
Merged

Fix append #43

merged 4 commits into from
Mar 19, 2021

Conversation

ihexxa
Copy link
Owner

@ihexxa ihexxa commented Mar 19, 2021

Please answer following questions before creating the PR:

  • What is this PR about?
    • fix(fs/local): remove O_APPEND for write_at
    • fix(files): clean download api
    • chore(workflows): add manual dispatch for docker
    • test(files): close fd in the progress of uploading
  • Is there any test which covers the change?
    • e2e test

@ihexxa ihexxa self-assigned this Mar 19, 2021
@ihexxa ihexxa merged commit a9ccb45 into main Mar 19, 2021
@ihexxa ihexxa deleted the fix-append branch March 19, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ihexxa ihexxa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ihexxa