New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server/files): fix Content-Disposition is not set #46

Merged

ihexxa merged 2 commits into main from fix-down-file-name

Apr 21, 2021

Owner

ihexxa commented Apr 18, 2021 •

edited

Please answer following questions before creating the PR:

What is this PR about?
- when downloading an excel file, it turns into a "files.zip", this is because Content-Disposition header is not set in normal downloading mode.
- fix flaky e2e tests
Is there any test which covers the change?
- will be added


          fix(server/files): fix Content-Disposition is not set

b669f03

ihexxa self-assigned this

ihexxa linked an issue

that may be closed by this pull request

下载问题 #45

Closed


          test(header): check content disposition header

1b101f1

ihexxa merged commit 8b5a80f into main

ihexxa deleted the fix-down-file-name branch

April 21, 2021 03:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment