Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combat screen, Captured Artifact window, artifact is displayed only once when opposing hero has two copies of the same artifact #8844

Closed
2 tasks done
LeHerosInconnu opened this issue Jun 17, 2024 · 3 comments · Fixed by #8845
Assignees
Labels
bug Something doesn't work regression Something went wrong in previous commits ui UI/GUI related stuff
Milestone

Comments

@LeHerosInconnu
Copy link

Preliminary checks

Platform

Windows

Describe the bug

In fheroes2, in the example, the opposing hero has two copies of the same artifact, but the artifact is displayed only once in Captured Artifact window.

In fheroes2:

Artifact two only one

2024-06-17.19-05-31.mp4

Save file

Not needed.

Additional info

No response

@LeHerosInconnu LeHerosInconnu added the bug Something doesn't work label Jun 17, 2024
@oleg-derevenetz
Copy link
Collaborator

This is a regression introduced in #8244.

@oleg-derevenetz oleg-derevenetz added ui UI/GUI related stuff regression Something went wrong in previous commits labels Jun 17, 2024
@oleg-derevenetz oleg-derevenetz added this to the 1.1.1 milestone Jun 17, 2024
@zenseii
Copy link
Collaborator

zenseii commented Jun 17, 2024

I remember when making that PR I was suprised that it worked that way, but iirc I checked the OG and that's how it worked, or that was how it was before the PR.

In either case, I'm completely fine with displaying duplicate artifacts.

@oleg-derevenetz
Copy link
Collaborator

Hi @zenseii

I remember when making that PR I was suprised that it worked that way, but iirc I checked the OG and that's how it worked, or that was how it was before the PR.

I understood that your idea was not to redraw the same artifacts running in a row, which is correct in general (and now the redraw is not being done either), you just shouldn't skip the event loop :)

@oleg-derevenetz oleg-derevenetz self-assigned this Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something doesn't work regression Something went wrong in previous commits ui UI/GUI related stuff
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants