Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the display of identical artifacts captured in battle #8845

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

oleg-derevenetz
Copy link
Collaborator

@oleg-derevenetz oleg-derevenetz commented Jun 17, 2024

fix #8844

Although there is nothing particularly wrong with a comparison using addresses of artifact names' strings, I still changed the comparisons to use artifact IDs.

@oleg-derevenetz oleg-derevenetz added bug Something doesn't work ui UI/GUI related stuff regression Something went wrong in previous commits labels Jun 17, 2024
@oleg-derevenetz oleg-derevenetz added this to the 1.1.1 milestone Jun 17, 2024
@oleg-derevenetz oleg-derevenetz marked this pull request as draft June 17, 2024 19:30
@oleg-derevenetz oleg-derevenetz marked this pull request as ready for review June 18, 2024 13:04
@ihhub ihhub requested review from Branikolog and removed request for zenseii June 23, 2024 13:29
@ihhub ihhub merged commit cf14d2a into ihhub:master Jun 26, 2024
21 checks passed
@ihhub
Copy link
Owner

ihhub commented Jun 26, 2024

@oleg-derevenetz , many thanks for this fix!

@oleg-derevenetz oleg-derevenetz deleted the captured-artifacts-display-fix branch June 26, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something doesn't work regression Something went wrong in previous commits ui UI/GUI related stuff
Projects
None yet
2 participants