Install non-dev SDL packages by default #3655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDL 1.2 and SDL 2 don't conflict
Add -d flag to install development packages.
oleg-derevenetz
added
improvement
Also fix macOS spelling in README
There was a problem hiding this comment.
Hi @qarkai I just left one question, please take a look when it will be convenient for you.
oleg-derevenetz
approved these changes
Jun 9, 2021
|
Hi @qarkai and @oleg-derevenetz , I remember there was a reason why we had to remove SDL 1 if we install SDL 2. I'll check it soon. |
|
@ihhub I'm not sure about Ubuntu, but on macOS I have both SDL1 and SDL2 libs installed (from MacPorts) without any issues, so I can switch between SDL1 and SDL2 just by adding/removing |
|
@qarkai , a bunch of thanks for improving the project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add separate scripts to install development packages.
Also don't remove other version of SDL before installation.
Fixes #2599.