Fix high FPS while right clicking on items in lists

[ihhub]

close #6518

We shouldn't consider a right mouse click as an event for full list redraw as this event serves as an information action.

IMPORTANT
This change requires heavy testing of all lists in the game as it modifies the behavior for all of them.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[Districh-ru]

Hi, @ihhub, I tested save/load, new game, town portal, kingdom overview, heroes, castles and select items lists. All works great, in Select game resolution/language dialogs right clicking does not provoke high FPS.
But I found one minor issue: in Battle Only open Select Monster dialog and right-click on any monster - you can notice that the info dialog is not closed immediately after releasing the right mouse button. This can be fixed in dialog_armyinfo.cpp at line 649 by placing this code (taken from the Quick View dialog code):

    // Restore background.
    restorer.restore();
    display.render( restorer.rect() );

This is not the issue of current PR because you can observe the same behavior when right-clicking any unit on the battlefield. But if you want, you can fix it here. :)

Also in one of the next PRs we should apply the same fix for holding the right mouse button on any empty monster/artifact/captain/secondary skill in castle, hero, kingdom overview or hero meting dialogs as it currently causes high FPS.

[Districh-ru]

After some checks for the cause of high FPS on every right mouse button hold on empty field (castle captain, secondary skill) in Kingdom Overview I found that this return value (true) is used to set redraw to true. In other places it seems that this state is used for the same purposes: to redraw screen or update data after changes.
But holding the right mouse button above the list item should not cause the change of any data. Therefore possibly we should return false here. What do you think, @ihhub?

PS High FPS on right mouse press on any empty artifact/unit in heroes meeting, hero and castle screens can be fixed

by changing:

fheroes2/src/fheroes2/army/army_bar.cpp

Lines 626 to 630 in e335ab2

	}
	}
	return true;
	}

and

fheroes2/src/fheroes2/resource/artifact.cpp

Lines 1240 to 1244 in e335ab2

	}
	}
	return true;
	}

to:

        }

        return true;
    }

    return false;
}

The solution is taken from:

fheroes2/src/fheroes2/gui/skill_bar.cpp

Lines 255 to 268 in e335ab2

	bool SecondarySkillsBar::ActionBarRightMouseHold( Skill::Secondary & skill )
	{
	if ( skill.isValid() ) {
	if ( can_change ) {
	skill.Reset();
	}
	else {
	fheroes2::SecondarySkillDialogElement( skill, _hero ).showPopup( Dialog::ZERO );
	}
	return true;
	}
	return false;
	}

[ihhub]

Hi @Districh-ru , I think we should also return a boolean value from ActionListPressRight as well to be consistent with the code.

[Districh-ru]

Hi, @ihhub, you are right, then ActionListPressRight() will return true if redraw is needed and we will return it from QueueEventProcessing().

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication