-
-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix high FPS while right clicking on items in lists #7647
Draft
ihhub
wants to merge
2
commits into
master
Choose a base branch
from
right_click_high_fps
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After some checks for the cause of high FPS on every right mouse button hold on empty field (castle captain, secondary skill) in Kingdom Overview I found that this return value (
true
) is used to setredraw
totrue
. In other places it seems that this state is used for the same purposes: to redraw screen or update data after changes.But holding the right mouse button above the list item should not cause the change of any data. Therefore possibly we should return
false
here. What do you think, @ihhub?PS High FPS on right mouse press on any empty artifact/unit in heroes meeting, hero and castle screens can be fixed
by changing:
fheroes2/src/fheroes2/army/army_bar.cpp
Lines 626 to 630 in e335ab2
and
fheroes2/src/fheroes2/resource/artifact.cpp
Lines 1240 to 1244 in e335ab2
to:
The solution is taken from:
fheroes2/src/fheroes2/gui/skill_bar.cpp
Lines 255 to 268 in e335ab2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Districh-ru , I think we should also return a boolean value from ActionListPressRight as well to be consistent with the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @ihhub, you are right, then
ActionListPressRight()
will return true if redraw is needed and we will return it fromQueueEventProcessing()
.