Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenCL implementation of IsEqual() function #562

Merged
merged 5 commits into from Oct 19, 2019

Conversation

manekenpix
Copy link
Contributor

Closes #451

Added IsEqual to src/opencl/image_function_opencl.h and src/opencl/image_function_opencl.cpp.

Also, added OpenCL kernel isEqualOpenCL to src/opencl/image_function_opencl.cpp.

@ihhub ihhub added OpenCL Computing language which is used for GPUs core Core image processing code labels Oct 11, 2019
@ihhub ihhub added this to the Release milestone Oct 11, 2019
Copy link
Owner

@ihhub ihhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @manekenpix, thank you for your efforts to fix this issue. Could you please take a look into my few comments?

src/opencl/image_function_opencl.cpp Outdated Show resolved Hide resolved
src/opencl/image_function_opencl.cpp Outdated Show resolved Hide resolved
@manekenpix manekenpix requested a review from ihhub October 11, 2019 12:54
@manekenpix
Copy link
Contributor Author

@ihhub let me know if there's anything else I can do so the code can be merged.

@ihhub ihhub merged commit b586c37 into ihhub:master Oct 19, 2019
@ihhub
Copy link
Owner

ihhub commented Oct 19, 2019

@manekenpix thank you very much for contribution to the project!

@manekenpix manekenpix deleted the isempty-opencl branch October 19, 2019 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core image processing code OpenCL Computing language which is used for GPUs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenCL implementation of IsEqual() function
2 participants