Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GBDSCI 6277 #127

Merged
merged 10 commits into from
Jun 4, 2024
Merged

GBDSCI 6277 #127

merged 10 commits into from
Jun 4, 2024

Conversation

everdyke
Copy link
Collaborator

Change error log table from client side to server side pagination

@everdyke everdyke changed the base branch from main to release/3.2 May 21, 2024 23:34
@everdyke everdyke mentioned this pull request May 21, 2024
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented May 22, 2024 •
edited
Loading

Test Results

220 tests  ±0   215 ✅ ±0   18m 32s ⏱️ -2s
  1 suites ±0     5 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit aaa0945. ± Comparison against base commit 8cf6b58.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  jobmon_server/src/jobmon/server/web/routes/v2/cli
  task_template.py 502-507, 520-547, 592
Project Total  

This report was generated by python-coverage-comment-action

mlsandar
mlsandar approved these changes Jun 4, 2024
View reviewed changes
Copy link
Collaborator

@mlsandar mlsandar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fancy work on the pagination. Well done

@everdyke everdyke merged commit 81b1607 into release/3.2 Jun 4, 2024
2 checks passed
@everdyke everdyke deleted the GBDSCI-6277 branch June 4, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlsandar mlsandar mlsandar approved these changes

@LimingXuIHME LimingXuIHME Awaiting requested review from LimingXuIHME LimingXuIHME is a code owner

@geoffreyphipps-uw geoffreyphipps-uw Awaiting requested review from geoffreyphipps-uw geoffreyphipps-uw is a code owner

@wcbzero wcbzero Awaiting requested review from wcbzero wcbzero is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@everdyke @mlsandar