Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests on PHP 7.3 #14

Merged
merged 1 commit into from Jul 8, 2019
Merged

Fix tests on PHP 7.3 #14

merged 1 commit into from Jul 8, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jun 27, 2019

When using time, PHP complains about time() expects exactly 0 parameters, 1 given, so use another function that PHP does not complain about.

1) NsplTest\FTest::testPartial
time() expects exactly 0 parameters, 1 given

/.../NSPL/nspl/f.php:53
/.../NSPL/tests/NsplTest/FTest.php:79

Fix tests on PHP 7.3
cd9e331 
When using time, PHP complains about "time() expects exactly 0 
parameters, 1 given", so use another function that PHP does not complain 
about.
@ihor
Copy link
Owner

ihor commented Jul 8, 2019

Thanks @tominventisbe !

@ihor ihor merged commit 483cb27 into ihor:master Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ihor