Update helper.py [fixes "SyntaxWarning: invalid escape sequence" in log file] #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes "SyntaxWarning: invalid escape sequence" in log file
deldesir
approved these changes
Mar 8, 2024
|
Very awesome: @jvonau what is your preference: should we merge this or better to get upstream to merge this instead? @OzzieIsaacs is an incredible contributor to humanitarians/users worldwide, so I believe he'd very likely be happy to accept your bugfix PR. |
holta
changed the title
|
Feel free to summit this on my behalf, I really don't have the time to devote to this. |
OzzieIsaacs
added a commit
to janeczku/calibre-web
that referenced
this pull request
Mar 10, 2024
|
I can't reproduce the error message with my Linux Mint 21.3, but I did a change similar to the suggested one. So I guess the message should now disappear |
|
Thanks @OzzieIsaacs — your patch looks right on here: |
daniel-edwards-iress
pushed a commit
to daniel-edwards-iress/calibre-web
that referenced
this pull request
Mar 18, 2024
Looks good, thanks to @jvonau and @OzzieIsaacs ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes "SyntaxWarning: invalid escape sequence" in log file