-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify playlists identification [for non-YouTube playlists e.g. Vimeo showcases, Bilibili.tv / Bilibili.com anthologies, etc] #173
Conversation
Quick explain/clarify the higher level purpose and/or mechanics of this PR, if you can? |
This is an attempt to support non-YouTube playlist like collections from other sites. i.e Vimeo showcases, Bilibili anthologies... |
Is this PR tested against Vimeo showcases and/or Bilibili anthologies? |
It's still in progress. I am thinking of moving the identification mechanism at database level instead for more reliability and to support all of the other sites. |
No obligation — but how close is this PR and/or others to being well tested and safely mergeable in coming hours for the weekly release? |
Very close. I am testing right now... one last small edit left to do. |
This PR works on bilibili videos, creating the bookshelf successfully, but be aware of yt-dlp/yt-dlp#10121. A workaround will be shipped in another PR. |
The current playlist and channel identification works only for YouTube. This PR simplifies the check before metadata is fetched.