Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify playlists identification [for non-YouTube playlists e.g. Vimeo showcases, Bilibili.tv / Bilibili.com anthologies, etc] #173

Merged
merged 6 commits into from
Jun 7, 2024

Conversation

deldesir
Copy link
Collaborator

@deldesir deldesir commented Jun 6, 2024

The current playlist and channel identification works only for YouTube. This PR simplifies the check before metadata is fetched.

@deldesir deldesir marked this pull request as draft June 6, 2024 04:24
@holta
Copy link
Member

holta commented Jun 6, 2024

@deldesir

Quick explain/clarify the higher level purpose and/or mechanics of this PR, if you can?

@deldesir deldesir requested a review from holta June 6, 2024 12:45
@deldesir deldesir self-assigned this Jun 6, 2024
@deldesir deldesir marked this pull request as ready for review June 6, 2024 12:46
@deldesir
Copy link
Collaborator Author

deldesir commented Jun 6, 2024

@deldesir

Quick explain/clarify the higher level purpose and/or mechanics of this PR, if you can?

This is an attempt to support non-YouTube playlist like collections from other sites. i.e Vimeo showcases, Bilibili anthologies...

@holta holta changed the title Simplify playlists identification Simplify playlists identification [for non-YouTube playlists e.g. Vimeo showcases, Bilibili.tv / Bilibili.com anthologies, etc] Jun 6, 2024
@holta
Copy link
Member

holta commented Jun 6, 2024

Is this PR tested against Vimeo showcases and/or Bilibili anthologies?

@deldesir
Copy link
Collaborator Author

deldesir commented Jun 6, 2024

It's still in progress. I am thinking of moving the identification mechanism at database level instead for more reliability and to support all of the other sites.

@deldesir deldesir marked this pull request as draft June 6, 2024 13:38
@holta
Copy link
Member

holta commented Jun 7, 2024

@deldesir:

No obligation — but how close is this PR and/or others to being well tested and safely mergeable in coming hours for the weekly release?

@deldesir
Copy link
Collaborator Author

deldesir commented Jun 7, 2024

@deldesir:

No obligation — but how close is this PR and/or others to being well tested and safely mergeable in coming hours for the weekly release?

Very close. I am testing right now... one last small edit left to do.

@deldesir deldesir marked this pull request as ready for review June 7, 2024 16:31
@deldesir deldesir added the enhancement New feature or request label Jun 7, 2024
@deldesir
Copy link
Collaborator Author

deldesir commented Jun 7, 2024

Done. Tested on Ubuntu 24.04.

image

@deldesir
Copy link
Collaborator Author

deldesir commented Jun 7, 2024

This PR works on bilibili videos, creating the bookshelf successfully, but be aware of yt-dlp/yt-dlp#10121. A workaround will be shipped in another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants