Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression due to ValueError in file uploading mechanism #210

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

deldesir
Copy link
Collaborator

@deldesir deldesir commented Jul 5, 2024

This PR removes renamed_authors argument to align with latest upstream changes. This fixes #209 preventing downloads to go through.

@deldesir deldesir added bug Something isn't working enhancement New feature or request labels Jul 5, 2024
@deldesir deldesir requested a review from holta July 5, 2024 13:19
@deldesir deldesir self-assigned this Jul 5, 2024
@holta
Copy link
Member

holta commented Jul 5, 2024

Testing summary?

@deldesir
Copy link
Collaborator Author

deldesir commented Jul 5, 2024

Fixed the issue. No ValueError logged in calibre-web.log. Tested on LRN2.

image

@holta holta merged commit 4257c30 into iiab:master Jul 5, 2024
@holta
Copy link
Member

holta commented Jul 5, 2024

Thanks @deldesir for uncovering & solving this upstream issue that arose yesterday!

Just FYI for the record @nzola seems to also have experienced this, in a different form ("500 INTERNAL SERVER ERROR") yesterday:

Installed iiab on p4 yesterday and tested Calibre-Web. It generate server error 500.

PUBLISHING TO URL... https://dpaste.com/9NMAHCQZ4

IMG-20240705-WA0005

IMG-20240705-WA0006

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
2 participants