Admin Console reports osm region as installed when it isn't #229
Assignees
Labels
Comments
|
I think this points to a bug. My code does not silently ignore checkboxes that are already installed -- and the alert probably does not display which region is already installed -- leading to confusion. |
holta
changed the title
|
Not sure what to say. The previous version did not have this problem. Multiple regions could be installed at once. Those already installed were silently skipped. This version can install one region at a time, but any installed region will mark all as installed. We plan to rewrite this later as the data and ui both have planned revisions. My vote is to go back to what we had before. |
|
I agree
…On Sun, Jun 30, 2019 at 11:26 AM Tim Moody ***@***.***> wrote:
Not sure what to say. The previous version did not have this problem.
Multiple regions could be installed at once. Those already installed were
silently skipped. This version can install one region at a time, but any
installed region will mark all as installed.
We plan to rewrite this later as the data and ui both have planned
revisions.
My vote is to go back to what we had before.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#229?email_source=notifications&email_token=AAOTQHA3KHG5EGTWXA6VS2LP5D3GDA5CNFSM4H4MZOT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY4RFZY#issuecomment-507056871>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAOTQHF2WYT6AQPY4HZHZYTP5D3GDANCNFSM4H4MZOTQ>
.
|
|
Or we could include in the alert the identity of the region is already
installed. I think that if one region is installed, and there are two check
boxes, the logic will flag the one that is already installed, and silently
go to work to install the second one.
…On Sun, Jun 30, 2019 at 11:28 AM George Hunt ***@***.***> wrote:
I agree
On Sun, Jun 30, 2019 at 11:26 AM Tim Moody ***@***.***>
wrote:
> Not sure what to say. The previous version did not have this problem.
> Multiple regions could be installed at once. Those already installed were
> silently skipped. This version can install one region at a time, but any
> installed region will mark all as installed.
>
> We plan to rewrite this later as the data and ui both have planned
> revisions.
>
> My vote is to go back to what we had before.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <#229?email_source=notifications&email_token=AAOTQHA3KHG5EGTWXA6VS2LP5D3GDA5CNFSM4H4MZOT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY4RFZY#issuecomment-507056871>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAOTQHF2WYT6AQPY4HZHZYTP5D3GDANCNFSM4H4MZOTQ>
> .
>
|
|
it won't. it will mark both as installed |
|
But if we changed line 304 from "break" to "continue" , and deleted the
alert for already installed, I would work, and not pester the user about
what was already installed.
…On Sun, Jun 30, 2019 at 11:34 AM Tim Moody ***@***.***> wrote:
it won't. it will mark both as installed
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#229?email_source=notifications&email_token=AAOTQHHZIVZLGWFNEHMR2PDP5D4E3A5CNFSM4H4MZOT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY4RJXY#issuecomment-507057375>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAOTQHC62JSTOFQ7QQGSOQTP5D4E3ANCNFSM4H4MZOTQ>
.
|
|
Just so I'm clear, will the functionality be different in any way from what was there before? |
|
Give me some time to set up a test case. I've been wrong too many times.
…On Sun, Jun 30, 2019 at 11:48 AM Tim Moody ***@***.***> wrote:
Just so I'm clear, will the functionality be different in any way from
what was there before?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#229?email_source=notifications&email_token=AAOTQHE4GKVGRCZD6RNOAYTP5D5ZJA5CNFSM4H4MZOT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY4RQVY#issuecomment-507058263>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAOTQHDTBPPKG74KQKQGYX3P5D5ZJANCNFSM4H4MZOTQ>
.
|
|
I suggest that we comment out the alert at 309 in admin-console.js. (PR 232
does this) ie: alert ("Selected Map Region is already installed.\n");
I've tested this fix.
It installs a second region, after a first one has already been installed
on an earlier click on the "install selected regions" button. It silently
refuses to attempt a second install of a region that is already installed
(no change from previous behavior).
I fudged the version of regions.json in
/library/www/osm-vector-maps/maplist/assets to request an earlier version
of a package that was already installed, and it downgraded properly.
…On Sun, Jun 30, 2019 at 12:19 PM George Hunt ***@***.***> wrote:
Give me some time to set up a test case. I've been wrong too many times.
On Sun, Jun 30, 2019 at 11:48 AM Tim Moody ***@***.***>
wrote:
> Just so I'm clear, will the functionality be different in any way from
> what was there before?
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <#229?email_source=notifications&email_token=AAOTQHE4GKVGRCZD6RNOAYTP5D5ZJA5CNFSM4H4MZOT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY4RQVY#issuecomment-507058263>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAOTQHDTBPPKG74KQKQGYX3P5D5ZJANCNFSM4H4MZOTQ>
> .
>
|
|
addendum to the report. I forgot to reboot the test machine, before
downloading a downgraded map region.
The front end thought it was downloading one thing, the backend downloaded
the same (unchanged) one again (the communication is via region name (via
the url associated with that region in regions.json, and the back end will
only pick up a changed regions.json at startup.
Probably more of a problem for testers, than it is for our installed base.
…On Sun, Jun 30, 2019 at 4:30 PM George Hunt ***@***.***> wrote:
I suggest that we comment out the alert at 309 in admin-console.js. (PR
232 does this) ie: alert ("Selected Map Region is already installed.\n");
I've tested this fix.
It installs a second region, after a first one has already been installed
on an earlier click on the "install selected regions" button. It silently
refuses to attempt a second install of a region that is already installed
(no change from previous behavior).
I fudged the version of regions.json in
/library/www/osm-vector-maps/maplist/assets to request an earlier version
of a package that was already installed, and it downgraded properly.
On Sun, Jun 30, 2019 at 12:19 PM George Hunt ***@***.***>
wrote:
> Give me some time to set up a test case. I've been wrong too many times.
>
> On Sun, Jun 30, 2019 at 11:48 AM Tim Moody ***@***.***>
> wrote:
>
>> Just so I'm clear, will the functionality be different in any way from
>> what was there before?
>>
>> —
>> You are receiving this because you commented.
>> Reply to this email directly, view it on GitHub
>> <#229?email_source=notifications&email_token=AAOTQHE4GKVGRCZD6RNOAYTP5D5ZJA5CNFSM4H4MZOT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY4RQVY#issuecomment-507058263>,
>> or mute the thread
>> <https://github.com/notifications/unsubscribe-auth/AAOTQHDTBPPKG74KQKQGYX3P5D5ZJANCNFSM4H4MZOTQ>
>> .
>>
>
|
|
I have not yet heard any reason not to go back to what was there before. |
|
The one before refused to install a new release of a region that was
already installed -- without hand editing of
../common/assets/vector-maps-idx.json.
…On Sun, Jun 30, 2019 at 4:43 PM Tim Moody ***@***.***> wrote:
I have not yet heard any reason not to go back to what was there before.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#229?email_source=notifications&email_token=AAOTQHEQJORARKJMWHW6MK3P5FAL5A5CNFSM4H4MZOT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY4WDAA#issuecomment-507076992>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAOTQHHGNPVZHHKPYZLKZCDP5FAL5ANCNFSM4H4MZOTQ>
.
|
This was referenced Jul 1, 2019
This was referenced Jul 15, 2019
|
@georgejhunt is this still an issue? (Or can I close parent ticket iiab/iiab#1793 now?) |
|
@georgejhunt suggests we close this and parent tkt iiab/iiab#1793, as he wrote up here: iiab/iiab#1793 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
after selecting en-osm-omt_middle_east_2017-07-03_v0.23/en-osm-omt_middle_east_2017-07-03_v0.23.zip I selected South America and got alert that already installed.
The text was updated successfully, but these errors were encountered: