Why are sp-* menuDefs being created, when es-* menuDefs already exist? [rewrite iiab-make-kiwix-lib.py & iiab_update_menus.py ?]

[holta]

I assume this is a bug but hopefully @tim-moody and @georgejhunt can clarify if "sp" is intended and if so why?

These menuDefs gets created when when downloading/installing Content Packs:

• sp-wikipedia_es_all_novid
• sp-wiktionary_es_all_novid
• sp-ecured_es_all
• sp-phet_es

This seems wrong, when carefully written menuDefs already exist for these, e.g.:

• es-wikipedia_es_all_novid
• es-wiktionary_es_all_novid
• es-ecured_es_all
• es-phet_html with es-phet_html.html

[holta]

See: iiab/iiab-admin-console#238 "iiab_update_menus uses wrong language code"

[holta]

@tim-moody is working hard to try solve this.

Just FWIW these 4 chunks from /library/www/html/common/assets/zim_version_idx.json aren't super-uniform/consistent, but possibly hint at the underlying issue(s):

2:  "wiktionary_es_all_novid": {
4:    "menu_item": "",
7:    "file_name": "wiktionary_es_all_novid_2018-10",

92: "phet_es": {
94:    "menu_item": "sp-phet_es",
97:    "file_name": "phet_es_2019-06",

172:  "ecured_es_all": {
174:    "menu_item": "sp-ecured_es_all",
177:    "file_name": "ecured_es_all_2019-05",

192:  "wikipedia_es_all_novid": {
194:    "menu_item": "sp-wikipedia_es_all_novid",
197:    "file_name": "wikipedia_es_all_novid_2019-06",

[holta]

Largely solved by PR #1878 and PR iiab/iiab-admin-console#239

@tim-moody tested this with a fresh d/l of a Spanish ZIM file.

@tim-moody writes:

this needs a rewrite however for maintenance

[holta]

@tim-moody suggests both of these could use a rewrite — using some kind of shared library:

• roles/kiwix/templates/iiab-make-kiwix-lib.py
• roles/cmdsrv/templates/scripts/iiab_update_menus.py

If not now then in the IIAB 7.1 release cycle?

[holta]

I assume this is fixed.

(@tim-moody please re-open if necessary.)