Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Admin Console: Selecting one vs multiple regions - checkboxes/radio buttons [OSM] #1785

Closed
avni opened this issue Jun 30, 2019 · 9 comments

Comments

@avni
Copy link
Member

avni commented Jun 30, 2019

Expected behavior and actual behavior.

Bug: Admin Console: The text on the page implies that I can only select one region to install, while the section where I select the regions are checkboxes, allowing me to select multiple regions. I would expect them to be radio buttons.

Steps to reproduce the problem.

Go to http://box.lan/admin/, Select "Install Content", Select "Get Map Region", View page.

Specifications like the version of the IIAB, operating system version, or hardware details.

Macbook Pro 2.7 Ghz 8 GB Ram
Mac OS Sierra 10.12.6
Chrome Version 74.0.3729.169
Server: RPI 4B Buster Lite
IIAB: 7.0 pre-release

@avni avni changed the title Bug: Admin Console: The text on the page implies that I can only select one region to install, while the section where I select the regions are checkboxes, allowing me to select multiple regions. I would expect them to be radio buttons. Bug: Admin Console: Selecting one vs multiple regions - checkboxes/radio buttons. Jun 30, 2019
@tim-moody
Copy link
Contributor

I thought Adam removed the text, which was never the case.

@tim-moody
Copy link
Contributor

please file admin console bugs against iiab-admin-console

@holta holta added this to the 7.0 milestone Jun 30, 2019
@holta
Copy link
Member

holta commented Jun 30, 2019

@georgejhunt please clarify your intentions as to what's best here going forward.

@avni would like radio buttons to make the user experience much more clear.

But you may have other plans, so just let us know, Thanks!

@holta holta changed the title Bug: Admin Console: Selecting one vs multiple regions - checkboxes/radio buttons. Bug: Admin Console: Selecting one vs multiple regions - checkboxes/radio buttons [OSM] Jun 30, 2019
@tim-moody
Copy link
Contributor

radio buttons are typically used to select on of set of options. further, the look and feel is that of zims and oer2go, which I am not prepared to change

@holta holta removed their assignment Jun 30, 2019
@tim-moody
Copy link
Contributor

we have discussed changes to this design, but not for release 7. It should work more like zims, where color coding shows state of install and installed are checked, but can't be unchecked.

@georgejhunt
Copy link
Contributor

It was never my intention to limit the number of regions that could be installed on IIAB to one. That was a comment that Adam put into the code without discussing it with me.

When we discussed the issue in at a recent call, where I asked him about the reason for limiting downloads to one, I did not understand his answer, and we left the subject without agreement.

For 7.1, it is my intention to separate the code from the data. There will be a single viewer for all maps. During the download process any new map data will be merged with one of the two sqlite databases (osm or satellite) -- hopefully with a tag added so that each addition can later be deleted separately (though I'm not sure that deletion is important enough to justify the complexity).

@holta
Copy link
Member

holta commented Jun 30, 2019

It was never my intention to limit the number of regions that could be installed on IIAB to one.

Certainly there is strong disagreement here. Many implementers and most attendees at https://linuxfestnorthwest.org/conferences/2019 who discussed this in late April, found the above to be a very confusing UX, that's not really helping schools.

If we cannot solve this fundamental disagreement for IIAB 7.0, we'll all do our best to work on our community listening skills for IIAB 7.1

Related:

#1726 It would be easier if map content packs did not bundle both code and data [OSM]

@holta
Copy link
Member

holta commented Jun 30, 2019

We are helping nobody when we merge changes in direct opposition to IIAB implementer community discussions:

iiab/iiab-admin-console#231

In any case, a group of IIAB implementers and volunteers went out of their way to meet in Washington State in April of 2019 at their own expense, and their input (that more explanation is needed by new implementers, in context within a confusing UX) is being directly ignored.

@holta holta modified the milestones: 7.0, 7.1 Jul 26, 2019
@holta holta modified the milestones: 7.1, 7.2 Dec 27, 2019
@avni
Copy link
Member Author

avni commented Sep 8, 2020

These are now radio buttons in 7.2 pre-release: http://192.168.0.172/osm-vector-maps/installer/

@avni avni closed this as completed Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants