Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logo corners are chopped: can this be prevented? #1862

Open
holta opened this issue Jul 12, 2019 · 2 comments
Open

Logo corners are chopped: can this be prevented? #1862

holta opened this issue Jul 12, 2019 · 2 comments

Comments

@holta
Copy link
Member

holta commented Jul 12, 2019

When viewing the internetarchive logo on the left side of an IIAB home page, the artwork's corners are removed (whited out), instead of showing the full (square) logo here:

https://github.com/iiab/iiab-admin-console/blob/master/roles/js-menu/files/menu-files/images/Internet_Archive_logo_and_wordmark.svg

Why is this happening?

Can this be prevented?

Context: This arises in the Chrome browser on Android (and likely in all other browsers, on all OS's?) when this new "Internet Archive Decentralized Web" IIAB playbook has been installed:
https://github.com/iiab/iiab/tree/master/roles/internetarchive

Ref: #1831

@holta
Copy link
Member Author

holta commented Jul 17, 2019

@floydianslips & @tim-moody today discussed several possible approaches to mitigate the worst of this cropping/chopping of logo corners (e.g. when a square/textual logo is all that's available). The issue likely results from this line within the CSS:

border-radius: 5px

Not easy figuring out what to do here:

  • While black-on-white logos like the 4 discussed above (for Internet Archive & en-wikisource) are certainly begging for an opt-out to avoid corner-cropping/rounding in these cases (which remain elegant) that's not however true in the general case for all JPG/PNG/GIF's — where this iOS/RACHEL-like corner-rounding seems desirable in most all cases.

On the topic of mobile phones and more generally grid views of such logos/icons (if that ever transpires, along the lines of #1866, with description+metadata on demand via mouseover/hover or similar?) it's worth noting that...

  • iOS mandates apps have squarish logos
  • recent versions of Android mandates that apps have circular logos [which can make for very awkward-or-at-least-very-small logos with limited screen real estate, when a square peg is put in a round hole ;)

@holta holta modified the milestones: 7.0, 7.1 Jul 26, 2019
@holta holta modified the milestones: 7.1, 7.2 Jan 3, 2020
@holta holta modified the milestones: 7.2, 8.0 Sep 10, 2020
@holta holta modified the milestones: 8.0, 8.1 Jan 1, 2022
@holta holta modified the milestones: 8.1, 8.2 Jan 1, 2023
@holta holta modified the milestones: 8.2, 8.3 Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant