New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Teachers want Accents to work when searching for cities in OpenStreetMap #662
Comments
if this is a bug it is at source. remember that the search db only has the 5000 largest cities in the world. I don't see that auto complete works on iiab.me. try León. maybe no accents in db. oaxaca search returns full name with an accent that fails to match to a map. just entering oaxaca goes to the map. |
Autocomplete works at iiab.me/modules/en-worldmap/map.html if you enter "Acap" or "acap" Observe the 3 autocomplete results — some of which are clickable — but not Acapulco, as its full name contains accent(s). This is an upstream bug no doubt, but universally requested by teachers in different states in Mexico. (Let's also consider upgrading from 5000 cities to 15,000 cities — which Mexican schools would appreciate greatly if it's doable!) |
the original iiab maps does know the difference between León and Leon |
sqlite> select * from features where name like 'oaxaca%'; |
Amazing...how close we are? I hope we can make kidproof geography a focus given every school I've talked to recently (elementary, middle, high) takes this very seriously. Whether or not locally comprehensive detail can be layered on, deepening these 10 base (National Geographic) layers within the local country/region! CC @m-anish |
rachel's search php is the source of the search problem. we need to define the search algorithm and then re-implement it. iiab's approach was better, but the ui is flawed. (actually we have not really tried Joel's subsequent changes. how close are we? not very. |
Could we restrict (typing) accents (into the textfield search box) in the short term? Since the cities are showing up correctly, except for the very final stage of visualizing them? (And work with @jasco too, for the longer-term solution below?)
|
@tim-moody is it possible you misunderstood? Accented cities ARE appearing correctly in the dropdown. The only thing that's not happening is the very, very final step — displaying the MAP of such accented cities — i.e. when users click on those accented cities in the dropdown. (This would seem to be a straightforward bug very possibly: if these accented cities' latitudes/longitudes are indeed known...seemingly these lat/long's are just getting messed up during the final tile-rendering stage?) |
@tim-moody explained during our community/team call (http://minutes.iiab.io) that he sees no easy way to fix this, without reworking the PHP logic — or possibly hacking the database to include plaintext unaccented citynames as well? In any case in Spanish-speaking countries, it would appear that something like 1/3 of all cities contain accents, and so currently do not display as a result of this bug. Crude-but-useful Workaround for Teachers:
You can try this live at http://dev.worldpossible.org/mods/en-worldmap-10/map.html (not perfect but better than nothing :-) |
this sounds like a good workaround and is even simpler than you say. type 'oaxaca' and press enter and the map will be positioned to Oaxaca. But pause and a drop down will appear and selection of an item in that dropdown with an accent will fail. Basically, if you press enter the entire search list is marked on the map with the map positioned to the item at the top of the list. Try typing 'par' and enter and zoom out to see the whole world. |
Good Catch: it tolerates even more letters, so that multiple cities need not be shown. Conclusion: teacher training can involve typing in all letters up to (but not including) the 1st accented character of the city name — and then hit Enter (or click on the magnifying glass) — but do not click on the actual accented city name in the dropdown! e.g. "Tuxtla G" works (shows the capital of Chiapas) better than "Tuxtla" (showing 2 different cities) — whereas "Tuxtla Gutiérrez" shows nothing at all. This doesn't solve all cases (i.e. when city names like "León" contain accents on the left side in the very 1st few letters, they're impossible to display) but still this workaround-for-teachers is a massive win, allowing geography classes to take this much more seriously. |
IIAB 6.5 has brought us many improvements here. Thanks to the many contributors who made this happen. Hopefully an even more complete solution will allow students/teachers to find OSM cities that contain accents in many languages — even without these recent training/UX hacks — as part of IIAB 6.6 or 7.0. |
Seems good enough! (But please re-opened as nec!) |
See @georgejhunt's heroic fix @ #659 that goes 90% of the way, but leaves teachers frustrated when their city shows up (autocomplete works!) but something about the geo-location fails, such that a map of their city never appears.
This is based on the 10.7GB National Geographic tiles from http://dev.worldpossible.org/cgi/viewmod.pl?module_id=100
The text was updated successfully, but these errors were encountered: