Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change filter-wildcard to * #31

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

danielhuppmann
Copy link
Member

The pyam package and the manager-service use * as a wildcard, whereas SQL uses %.

This PR changes the API to be consistent with pyam, and also adding escaping to the string-like-filters so that it is possible to filter (only) for the percentage sign as a unit.

@danielhuppmann danielhuppmann self-assigned this Nov 23, 2023
@danielhuppmann danielhuppmann marked this pull request as ready for review November 23, 2023 11:18
Copy link
Contributor

@meksor meksor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danielhuppmann danielhuppmann merged commit 6eead51 into iiasa:main Nov 23, 2023
4 checks passed
@danielhuppmann danielhuppmann deleted the filter/wildcard branch November 23, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants