Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate cat features from ixmp.Scenario #125

Merged
merged 5 commits into from
Nov 14, 2018
Merged

Conversation

gidden
Copy link
Member

@gidden gidden commented Nov 13, 2018

update unit test properties file in line with new db-connection args

migrate cat tests to message_ix.Scenario

update clone() API to keep_solution()

update test-db

change all tests to message_ix.Scenario and new API

udpate MESSAGE-version in GAMS code, change to MAJOR.MINOR.PATCH format

remove manual addition of MESSAGE sets and parameters in core.py

harmonize setting of auxiliary set all_modes

stickler appeasement

rename cols for new parameters in tests

add to release notes

Please confirm that this PR has done the following:

  • Tests Added
  • Documentation Added
  • Description in RELEASE_NOTES.md Added

Adding to RELEASE_NOTES.md

Please add a single line in the release notes similar to the following:

- (#XX)[http://link-to-pr.com] Added feature which does something

update unit test properties file in line with new db-connection args

migrate `cat` tests to `message_ix.Scenario`

update `clone()` API to `keep_solution()`

update test-db

change all tests to `message_ix.Scenario` and new API

udpate MESSAGE-version in GAMS code, change to `MAJOR.MINOR.PATCH` format

remove manual addition of MESSAGE sets and parameters in `core.py`

harmonize setting of auxiliary set `all_modes`

stickler appeasement

rename cols for  new parameters in tests

add to release notes
message_ix/core.py Outdated Show resolved Hide resolved
message_ix/cli.py Outdated Show resolved Hide resolved
@gidden
Copy link
Member Author

gidden commented Nov 14, 2018

Per my conversation with @zikolach, we have decided to proceed as follows:

Ok

So just to clarify my understanding

I'm not sure what users may or may not have applied

We know that the schema files had an issue between the two releases

But we now have a system in place to prevent that (notably they live in ixmp source)

So for this release, users may observe migration errors

And given that we have low confidence in whether they will be uniform across the user base

We should probably suggest they simply regenerate their databases

@gidden gidden merged commit 384bf6a into hackathon-prs Nov 14, 2018
@gidden gidden mentioned this pull request Nov 14, 2018
@gidden gidden deleted the try-again-prs branch November 14, 2018 14:47
gidden added a commit that referenced this pull request Nov 14, 2018
* migrate `cat` features from `ixmp.Scenario`

update unit test properties file in line with new db-connection args

migrate `cat` tests to `message_ix.Scenario`

update `clone()` API to `keep_solution()`

update test-db

change all tests to `message_ix.Scenario` and new API

udpate MESSAGE-version in GAMS code, change to `MAJOR.MINOR.PATCH` format

remove manual addition of MESSAGE sets and parameters in `core.py`

harmonize setting of auxiliary set `all_modes`

stickler appeasement

rename cols for  new parameters in tests

add to release notes

* general error in cli

* try again

* regenerate again with new jar file

* Rolled back test DB schema to migration 1.3 (#126)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants