-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/revise the maths formulations #388
base: main
Are you sure you want to change the base?
Conversation
@Jihoon since you raise some uncertain issues in the PR description, but I see no response or resolution yet, I will postpone this to v3.3. I would suggest to explicitly ask specific people for answers those questions; or guess at an appropriate answer and have a discussion with ≥1 other colleague to confirm that the changes are reasonable. |
Postponed to v3.4:
|
I've added the WIP tag, since there is still more time/investigation needed to finish up the PR, as discussed in today's MESSAGEix meeting. Due to that and the following
we postpone to v3.5. |
To bring the PR further, the following tasks and responsibilities have resulted:
|
As this PR is still in the "Draft" stage, we postpone to v3.6. |
Removing the milestone entirely. It can be re-added if/when the team decides to schedule/assign the work. |
As discussed in today's meeting, we should
|
I find the documentation on the core math formulation is not quite standalone by itself and ends up being quite confusing to external users. It requires filling in or fixing some missing parts to better communicate the formulation doc. I open this PR, but I don't really know answers to all these.
===
Some examples I found:
I didn't check all, but multiple equations contain unexplained subscripts, which can only be guessed. (e.g. h^{OD})
Sometimes T^R or L^R is used to mean T^{REN} or L^{REN}.
===
Also, I am not sure whether it is a standard notation in the modeling community, but denoting subsets like N(n_hat) is confusing because it usually means functions. Why don't we use N^{n_hat}, just like it does for T^{REN}.