Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test more specific to avoid error #767

Merged
merged 1 commit into from Dec 19, 2023

Conversation

glatterf42
Copy link
Member

@glatterf42 glatterf42 commented Dec 19, 2023

The recent dask update has brought to light an issue with one of our tests. test_macro.py:test_config wants to test, among others, that a missing column is causing a related error message. However, the test deletes three columns from the config and with the recent update, a different column from the expected one is picked up for the error message. This PR changes the test to delete only the one column from the config that we expect in the error message.

How to review

  • Read the diff and note that the CI checks all pass.

PR checklist

  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅
  • [ ] Add, expand, or update documentation. Just tests
  • [ ] Update release notes. Just tests

@glatterf42 glatterf42 added bug Doesn't work as advertised/unintended effects ci Continuous integration labels Dec 19, 2023
@glatterf42 glatterf42 added this to the 3.8 milestone Dec 19, 2023
@glatterf42 glatterf42 self-assigned this Dec 19, 2023
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Merging #767 (19391bf) into main (6b4f630) will not change coverage.
The diff coverage is 100.0%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #767   +/-   ##
=====================================
  Coverage   95.2%   95.2%           
=====================================
  Files         46      46           
  Lines       4312    4312           
=====================================
  Hits        4107    4107           
  Misses       205     205           
Files Coverage Δ
message_ix/tests/test_macro.py 100.0% <100.0%> (ø)

@glatterf42 glatterf42 merged commit d671101 into iiasa:main Dec 19, 2023
18 checks passed
@glatterf42 glatterf42 deleted the fix/test-failures branch December 19, 2023 08:31
khaeru added a commit that referenced this pull request Jan 10, 2024
glatterf42 pushed a commit that referenced this pull request Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Doesn't work as advertised/unintended effects ci Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant