Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump GAMS version in CI workflows to adjust for ixmp changes #863

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

glatterf42
Copy link
Member

@glatterf42 glatterf42 commented Jul 10, 2024

iiasa/ixmp#532 deleted some libraries that were used to run GAMS, which should now be read directly from a GAMS subdirectory. This PR adjusts the version of GAMS used in CI to check if this newer version enables finding the libraries.

How to review

  • Read the diff and note that the CI checks all pass.

PR checklist

  • Continuous integration checks all ✅
  • [ ] Add or expand tests; coverage checks both ✅ Just internal CI.
  • [ ] Add, expand, or update documentation. Just internal CI.
  • [ ] Update release notes. Just internal CI.

@glatterf42 glatterf42 added the ci Continuous integration label Jul 10, 2024
@glatterf42 glatterf42 requested a review from khaeru July 10, 2024 07:29
@glatterf42 glatterf42 self-assigned this Jul 10, 2024
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.6%. Comparing base (0bf321d) to head (d9ee307).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #863   +/-   ##
=====================================
  Coverage   95.6%   95.6%           
=====================================
  Files         46      46           
  Lines       4333    4333           
=====================================
  Hits        4143    4143           
  Misses       190     190           

@khaeru khaeru merged commit 6b86116 into main Jul 10, 2024
24 checks passed
@khaeru khaeru deleted the fix/gams-CI-version branch July 10, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants