Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add __ANDROID__: some compiler uses this instead of __android__. #15

Closed
wants to merge 1 commit into from

Conversation

ikeji
Copy link

@ikeji ikeji commented Sep 13, 2018

My compiler (clang which provided by termux project) defined __ANDROID__ and does not defined __android__.
This PR addes defined(__ANDROID__) to support these compiler.

Seems like gcc also uses __ANDROID__.
https://gcc.gnu.org/onlinedocs/gcc-4.7.4/gcc/GNU_002fLinux-Options.html

@tsahara
Copy link
Member

tsahara commented Sep 14, 2018

Can we just replace __android__ with __ANDROID__? All codes I can find in GitHub use __ANDROID__ for Android specific things.

@tsahara
Copy link
Member

tsahara commented Sep 14, 2018

I found that mruby uses __ANDROID__ (here), so it is better to do the same here. I'll commit the change. Thanks!

@tsahara tsahara closed this in 89dceef Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants