Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable app links to get to specific units #47

Closed
bsenyk opened this issue Dec 11, 2015 · 3 comments
Closed

Enable app links to get to specific units #47

bsenyk opened this issue Dec 11, 2015 · 3 comments
Assignees
Labels
Milestone

Comments

@bsenyk
Copy link
Collaborator

bsenyk commented Dec 11, 2015

No description provided.

@bsenyk bsenyk added this to the v0.1.0 milestone Dec 11, 2015
@bsenyk
Copy link
Collaborator Author

bsenyk commented Dec 29, 2015

Links should be in the following format:

General links: openmentoring://
Specific unit links: openmentoring://units/understand-4-digisec_4-secure-communications

@bsenyk bsenyk added in progress and removed ready labels Jan 8, 2016
bsenyk added a commit that referenced this issue Jan 13, 2016
@bsenyk
Copy link
Collaborator Author

bsenyk commented Jan 13, 2016

Links between units should use the ionic routes for them.

For example: #/app/topics?unit=understand-4-digisec_4-secure-communications

@bsenyk
Copy link
Collaborator Author

bsenyk commented Jan 13, 2016

The basic version of this is complete, however there are 2 known potential issues:

It doesn't check to see if the linked unit has been downloaded yet. There is already an issue for this -- #56

It is currently opening a new modal in front of the one that links to it. This means that if the user exits the linked unit, they will end up in the one they were in before they followed the link. I don't think this is ideal. @jmatsushita what do you think? If it should replace the current modal instead, we can create a separate ticket for that.

@bsenyk bsenyk added review and removed in progress labels Jan 13, 2016
@bsenyk bsenyk self-assigned this Jan 13, 2016
@bsenyk bsenyk closed this as completed in 0a49c07 Jan 13, 2016
@bsenyk bsenyk removed the review label Jan 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant