IINA stopped responding after quit clicked #4310
Assignees
Comments
|
I have seen this happen a couple of times too, but only while running via XCode, so wasn't sure whether it was caused by XCode or its debugger. |
|
Catching me before I have fully analyzed this one, but I suspect it is due to an issue you pointed out, that mpv sends a bunch of events when stopping that we should not be processing. I will be looking into whether this is a delayed forced drawing in reaction to one of those events. |
low-batt
added a commit
that referenced
this issue
Apr 20, 2023
This commit will: - Change MPVController to call PlayerCore when certain properties change - Add checking for shutting down before processing property changes - Change MPVController.handlePropertyChange to use the value passed in the event for the property idleActive - Move setting of the PlayerCore properties isStopping and isStopped to the openMainWindow method Once the asynchronous quit command has been sent to mpv IINA must not call certain mpv methods. This is a mpv requirement. Violating this requirement can result in crashes. Because mpv will still emit property change events the burden is on IINA to know that mpv has been told to quit and the property change events should not be processed. This commit moves code in MPVController that was calling various PlayerCore methods into PlayerCore and adds checks to ignore the property changes if IINA is shutting down the mpv core.
2 tasks
2 tasks
uiryuu
pushed a commit
that referenced
this issue
Apr 22, 2023
This commit will: - Change MPVController to call PlayerCore when certain properties change - Add checking for shutting down before processing property changes - Change MPVController.handlePropertyChange to use the value passed in the event for the property idleActive - Move setting of the PlayerCore properties isStopping and isStopped to the openMainWindow method Once the asynchronous quit command has been sent to mpv IINA must not call certain mpv methods. This is a mpv requirement. Violating this requirement can result in crashes. Because mpv will still emit property change events the burden is on IINA to know that mpv has been told to quit and the property change events should not be processed. This commit moves code in MPVController that was calling various PlayerCore methods into PlayerCore and adds checks to ignore the property changes if IINA is shutting down the mpv core.
uiryuu
pushed a commit
that referenced
this issue
Apr 22, 2023
This commit will: - Change MPVController to call PlayerCore when certain properties change - Add checking for shutting down before processing property changes - Change MPVController.handlePropertyChange to use the value passed in the event for the property idleActive - Move setting of the PlayerCore properties isStopping and isStopped to the openMainWindow method Once the asynchronous quit command has been sent to mpv IINA must not call certain mpv methods. This is a mpv requirement. Violating this requirement can result in crashes. Because mpv will still emit property change events the burden is on IINA to know that mpv has been told to quit and the property change events should not be processed. This commit moves code in MPVController that was calling various PlayerCore methods into PlayerCore and adds checks to ignore the property changes if IINA is shutting down the mpv core.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
System and IINA version:
Expected behavior:
After clicking on
Quit IINAunder theIINAmenu the application terminates.Actual behavior:
Rarely after clicking on
Quit IINAIINA does not terminate and becomes unresponsive.quit-hang-process-sample.txt
Steps to reproduce:
Click on
Quit IINAunder theIINAmenu while a video is playing.Unknown.
How often does this happen?
Rarely. Very difficult to reproduce. First time I have seen this.
The text was updated successfully, but these errors were encountered: