Fix stopped responding after quit clicked, #4310 #4368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
uiryuu
approved these changes
Apr 22, 2023
23 tasks
This commit will: - Change MPVController to call PlayerCore when certain properties change - Add checking for shutting down before processing property changes - Change MPVController.handlePropertyChange to use the value passed in the event for the property idleActive - Move setting of the PlayerCore properties isStopping and isStopped to the openMainWindow method Once the asynchronous quit command has been sent to mpv IINA must not call certain mpv methods. This is a mpv requirement. Violating this requirement can result in crashes. Because mpv will still emit property change events the burden is on IINA to know that mpv has been told to quit and the property change events should not be processed. This commit moves code in MPVController that was calling various PlayerCore methods into PlayerCore and adds checks to ignore the property changes if IINA is shutting down the mpv core.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will:
MPVControllerto callPlayerCorewhen certain properties changeMPVController.handlePropertyChangeto use the value passed in the event for the propertyidleActivePlayerCorepropertiesisStoppingandisStoppedto theopenMainWindowmethodOnce the asynchronous quit command has been sent to mpv IINA must not call certain mpv methods. This is a mpv requirement. Violating this requirement can result in crashes. Because mpv will still emit propery change events the burden is on IINA to know that mpv has been told to quit and the property change events should not be processed.
This commit moves code in
MPVControllerthat was calling variousPlayerCoremethods intoPlayerCoreand adds checks to ignore the property changes if IINA is shutting down the mpv core.Description: