Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lost localization of many strings #4481

Closed
woshiniming007 opened this issue Jul 9, 2023 · 3 comments · Fixed by #4484
Closed

lost localization of many strings #4481

woshiniming007 opened this issue Jul 9, 2023 · 3 comments · Fixed by #4484
Assignees
@svobs
Labels
bug: regression priority: high progress: fixed/implemented

Comments

@woshiniming007
Copy link

  • macOS 12.6
  • IINA 1.3.2

After upgraded to 1.3.2, some localization lost, such as the following panel:
截屏2023-07-09 22 02 08

And there are some other strings in English but I'm not sure if it is new in this version.
@svobs
Copy link
Contributor

svobs commented Jul 10, 2023 •
edited

Looks like I broke this while I was refactoring QuickSettingsViewController. While I was banging my head against the Video Settings tab, I deleted and recreated some of the text fields, which changed their IDs. I didn't realize at the time that those were needed for localization. Will post a PR which will fix this by changing back to the old IDs.

@svobs svobs mentioned this issue Jul 10, 2023
Merged
2 tasks
@svobs
Copy link
Contributor

svobs commented Jul 10, 2023

In the PR, I regenerated the file iina/en.lproj/QuickSettingViewController.strings and saw that entries for some minor text are currently missing from develop, such as the s in the time sliders. See the PR for more. But the most glaring omission was for +12 dB:
SCR-20230709-owme

@svobs
Copy link
Contributor

svobs commented Jul 10, 2023 •
edited

Also out of scope for this bug, looks like the Traditional Chinese translation for "Gamma" is listed simply as "Gamma":
SCR-20230709-teup

@low-batt low-batt linked a pull request Jul 11, 2023 that will close this issue
Fixes to Quick Settings regressions (fixes #4481, #4482) #4484
Merged
2 tasks
uiryuu pushed a commit that referenced this issue Jul 12, 2023
@svobs
Fixes to Quick Settings regressions (fixes #4481, #4482) (#4484)
9a109ae 
* Revert some IDs which got changed which broken some localizations. Regenerate en.lproj/QuickSettingViewController.strings. Fix broken "Custom…" localization ref. Fix some uses of "…" which were using "..." instead.

* Fix regression: audio delay text field not accepting negative values
@low-batt low-batt mentioned this issue Aug 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@svobs svobs

Labels
bug: regression priority: high progress: fixed/implemented
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes to Quick Settings regressions (fixes #4481, #4482) svobs/iina-advance
3 participants
@svobs @woshiniming007 @low-batt