Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting negative audio delay using text field is not working #4482

Closed
saneef opened this issue Jul 9, 2023 · 2 comments · Fixed by #4484
Closed

Setting negative audio delay using text field is not working #4482

saneef opened this issue Jul 9, 2023 · 2 comments · Fixed by #4484

Comments

@saneef
Copy link

saneef commented Jul 9, 2023

System and IINA version:

  • macOS 13.4.1
  • IINA 1.3.2 Build 135

Expected behavior:
Setting a delay of negative value, like -1, using text field should apply the value.

Actual behavior:
Negative values are ignored.


Steps to reproduce:

  • Open a video.
  • Open Audio panel, using the menu, 'Audio > Show Audio Panel'.
  • Type in a delay of negative value, like -2

How often does this happen?

Everytime.

@low-batt
Copy link
Contributor

Thank you very much for reporting this.

Reproduced for me. I confirmed this is working in IINA 1.3.1. This is a regression.

A brief look at the quick settings view controller XIB shows the NSNumberFormatter for the audio delay is configured with a 0.01 minimum value whereas the similar formatter for subtitle delay, which is working, has no minimum configured. I believe the setting of the minimum restriction was added in commit 64d4883.

uiryuu pushed a commit that referenced this issue Jul 12, 2023
* Revert some IDs which got changed which broken some localizations. Regenerate en.lproj/QuickSettingViewController.strings. Fix broken "Custom…" localization ref. Fix some uses of "…" which were using "..." instead.

* Fix regression: audio delay text field not accepting negative values
@low-batt low-batt linked a pull request Jul 12, 2023 that will close this issue
2 tasks
@low-batt
Copy link
Contributor

low-batt commented Jan 2, 2024

This is fixed in the released version of IINA.

@low-batt low-batt closed this as completed Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants