Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PlaylistLoop button state doesn't update with menu item #2973

Closed
wants to merge 1 commit into from

Conversation

mathric
Copy link
Contributor

@mathric mathric commented Jun 10, 2020

  • This change has been discussed with the author.
  • It implements / fixes issue #.

Description:
Fixing the issue that clicking the PlaylistLoop menu item doesn't update the PlaylistLoop button state in PlaylistView when the PlaylistView already loaded.

@lhc70000
Copy link
Member

lhc70000 commented Jul 8, 2020

Thanks for your contribution and sorry for my late reply.

I just found that those two buttons are not synced with mpv status at all, which makes it a more complicated problem than I thought. We should also observe mpv property changes and post notifications to update the UI when needed.

If you don't mind, I'm going to continue your work to finish the implementation. I'll merge your commit into a temporary working branch and your contribution will be preserved.

@lhc70000
Copy link
Member

lhc70000 commented Jul 8, 2020

Pushed to 6b9bd35

@lhc70000 lhc70000 closed this Jul 8, 2020
@mathric
Copy link
Contributor Author

mathric commented Jul 8, 2020

Thanks for your reply! It's fine if you're going to finish the implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants