Default mpv input conf: Remove {encode}, replace current-window-scale with window-scale #4063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svobs
force-pushed
the
pr-mpv-input-dot-conf
branch
from
68ea70a
to
1830717
Compare
|
I have pulled this PR locally and confirmed it fixes issue #4053. However the PR includes 155 commits including one that says "DO NOT MERGE". That sure does not look correct. |
…ed by IINA. Replace `set current-window-scale` bindings with `set window-scale` bindings: the former are not supported, but the latter are and were used in previous versions of the file. Also remove `default-bindings start` as it is not supported
svobs
force-pushed
the
pr-mpv-input-dot-conf
branch
from
1830717
to
72a772f
Compare
|
Yikes. Sorry about that! I think at the time I had 4 different branches checked out locally. Must have gotten confused which place I was branching from, or something like that... Did a new push. Should be just 1 commit with 1 file now. |
low-batt
approved these changes
Nov 27, 2022
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
set window-scalecommands were changed toset current-window-scalein mpv 0.34, but IINA does not support them. This changes them back to prevent user confusion and to be more useful.default-bindings start. It was commented out, but users shouldn't assume it will work if uncommented.