-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playback History Window: add confirmation before delete from keypress, add DEL key trigger, remove {modifier}+BS triggers #4256
Conversation
…eleted selected items. Change so that only DEL and BS keys (no modifiers) kick off delete. Also add confirmation before delete.
Failed my testing. Sometimes the history entry is deleted when I confirm the deletion and sometimes not. When the entry is not deleted the array Glad you noticed this problem. Definitely needs to be fixed. |
…get incorrect rows.
Good catch. I pushed an update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pulled latest commit, built IINA and tested under macOS 13.2.1. All seems to be working. Looks good to me.
break | ||
} | ||
} else { | ||
let key = KeyCodeHelper.mpvKeyCode(from: event) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using mpvKeyCode
here is a little weird to me, although its not unacceptable, but don't we have other elegant way to do this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well - I don't think so....It looks like MacOS's original design was never made more friendly in this regard, so I think we either have to use hexcodes or use our own constants. I was following the pattern set in the welcome window..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe later on we can refactor this part, maybe to abstract another helper function...
2fdc19a
to
9796116
Compare
Description:
Uses KeyCodeHelper to translate like in the welcome window.