Add the input module for the plugin system
#4569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
One of the two remaining API modules to be added in IINA 1.4.0. The other one would be a method to communicate with external programs (I'm considering WebSocket).
Please see the documentation for this module at: https://docs.iina.io/interfaces/IINA.API.Input.
This PR also contains a fix to a regression added in #4464.
The ultimate goal for this module is to let the plugin have the opportunity to accept and intercept various input events. However, much work needs to be done if we want to fully support that.
The implementation contained in this PR only allows users to intercept keyDown and keyUp events passed to the main window, and listen to the mouseUp events. This is already enough for features like "hold to seek" or "hold to speedup". We hope to add more functions in the future, but that requires some serious effort.
Please feel free to comment about the API design.