Add range request handling to TransparentReplayRenderer. #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * requested range. | ||
| * @see org.archive.wayback.replay.TransparentReplayRenderer | ||
| */ | ||
| public class RangeNotSatisfiable extends SpecificCaptureReplayException { |
There was a problem hiding this comment.
Shouldn't this class be named 'RangeNotSatisfiableException'. I think that is the common convention for exceptions.
There was a problem hiding this comment.
That's fine, too.
As you might guess, I named it after the standard name for 406 response "Requested Range Not Satisfiable". It is for returning 406 response, and it is not meant to be caught by that specific name. So I didn't see a need to follow that -Exception convention.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Limitations; it does not support multi-range requests, and capture must
have either Content-Length or instance-length in Content-Range)
#179, also internetarchive#78