Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated format-changelog to generate release lines for dependent packages #142

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

ijlee2
Copy link
Owner

@ijlee2 ijlee2 commented Apr 22, 2024

No description provided.

@ijlee2 ijlee2 added the enhance: documentation Issue asks for better documentation (e.g. README, code, tests) label Apr 22, 2024
Copy link

netlify bot commented Apr 22, 2024

Deploy Preview for embroider-css-modules ready!

Name Link
🔨 Latest commit d8d7e0b
🔍 Latest deploy log https://app.netlify.com/sites/embroider-css-modules/deploys/6626222e8ab95a0008973df4
😎 Deploy Preview https://deploy-preview-142--embroider-css-modules.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

}

async function getReleaseLine(changeset) {
async function getDependencyReleaseLine(changesets) {
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should packages in embroider-css-modules depend on one another, getDependencyReleaseLine() helps ensure that dependent packages get changelog entries and a version bump.

@ijlee2 ijlee2 marked this pull request as ready for review April 22, 2024 08:40
@ijlee2 ijlee2 merged commit 63b63f8 into main Apr 22, 2024
50 checks passed
@ijlee2 ijlee2 deleted the update-format-changelogs branch April 22, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhance: documentation Issue asks for better documentation (e.g. README, code, tests)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant