Remove opt_chars and get_value #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Breaking changes: add_opt_characteristic * Removed opt_characteristics
* Breaking changes: get_characteristic * Only takes the name of the char to search for (no check_optional parameter) * Raises ValueError instead of return None if not found
* Breaking changes: removed get_value * Use char.value instead
|
This is just perfect. I had doubts about removing the |
|
I don't think that it will. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit cleanup.
Removed:
Breaking changes:
add_opt_characteristic. There is no further distinction between optional and require chars during execution. All chars that have been added asoptionalshould now simply useadd_characteristic. (The loader hasn't changed.)get_characteristicnow raises aValueErrorif the characteristic isn't foundget_valuewas removed. Usechar.valueinstead.