Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Allow install if non-toplevel project. #73

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

KerstinKeller
Copy link
Contributor

If another project vendors termcolor (via add_subdirectory) and tries to install, the resulting package is not usable.
Let's say the top level project has a CMakeLists.txt like this:

cmake_minimum_required(VERSION 3.20)

project(my_project)
add_subdirectory(termcolor)

The generated termcolor-config.cmake will want to include my_project-targets.cmake instead of termcolor-targets.cmake.

By changing CMAKE_PROJECT_NAME to PROJECT_NAME in config.cmake.in this problem is solved.

If another project vendors termcolor (via `add_subdirectory`) and tries to install, the resulting package is not usable.
By changing `CMAKE_PROJECT_NAME` to `PROJECT_NAME` in `config.cmake.in` this problem is solved.
@ikalnytskyi ikalnytskyi merged commit 3477937 into ikalnytskyi:master Aug 6, 2024
@ikalnytskyi
Copy link
Owner

Makes sense. Thank you for your contribution. I'm sorry for not merging this earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants