Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RemapPal doesn't support source = -1, 0 in helper, or omitted source; Tested on 0.98.2 #1001

Closed
beterhans opened this issue Feb 26, 2023 · 2 comments · Fixed by #1059
Closed
Labels
bug Something isn't working

Comments

@beterhans
Copy link

beterhans commented Feb 26, 2023

Describe the bug

Original 1.1 document
If src_pal_grp is -1, all indexed-color sprites will be remapped to the dest palette. This only affects sprites of the same color depth as the dest palette. All other existing mappings will be removed.

If dst_pal_grp is -1, the mapping for the source is removed. Setting the dest pair to the same values as the source pair has the same effect.

To Reproduce

type = RemapPal
triggerall = !IsHelper
triggerall = RoundState < 1 && RoundsExisted = 0
trigger1 = 1
source = -1, 0
dest = 1, 1

or
type = RemapPal
triggerall = !IsHelper
triggerall = RoundState < 1 && RoundsExisted = 0
trigger1 = 1
dest = 1, 1

Expected behavior

I'm expecting without knowing current sprite index, but able to remap to a new color palette.
in Mugen 1.1 is possible but in IKEMEN not possible. you need to state the correct source index, which is difficult to know sometime. for example a FX helper

Screenshots / Video

video explanation
https://www.youtube.com/watch?v=zc-QyfyGsH4

Character in the video
https://www.patreon.com/posts/saber-dec-2022-75311447

Engine Version (or source code date)

v0.98.2

Operating system

Windows 10

Extra context or search terms

No response

@K4thos
Copy link
Member

K4thos commented Feb 27, 2023

I don't fully understand the documentation description. Please upload character that showcases the issue with the code already implemented.

@beterhans beterhans changed the title RemapPal doesn't support source = -1, 0; Tested on 0.98.2 RemapPal doesn't support source = -1, 0 in helper, or omitted source; Tested on 0.98.2 Feb 27, 2023
@beterhans
Copy link
Author

I don't fully understand the documentation description. Please upload character that showcases the issue with the code already implemented.

HI @K4thos
Added

Screenshots / Video

video explanation
https://www.youtube.com/watch?v=zc-QyfyGsH4

Character in the video
https://www.patreon.com/posts/saber-dec-2022-75311447

@K4thos K4thos added the bug Something isn't working label Feb 27, 2023
@K4thos K4thos closed this as completed in 105cf55 Mar 16, 2023
K4thos added a commit that referenced this issue Mar 16, 2023
fix: helper remapPal during first frame of the match, omitting source/dest and assignment to -1 (#1058, #1001)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants