Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.1 - Full Static #28

Merged
merged 17 commits into from
Feb 1, 2021
Merged

v3.1 - Full Static #28

merged 17 commits into from
Feb 1, 2021

Conversation

iksaku
Copy link
Owner

@iksaku iksaku commented Jan 13, 2021

v3 of the web app introduced some new features, which are pretty handy for diverse types of searching,
however, it also suffers from some pain points and has introduced some bugs.

For the sake of simplicity, this PR will introduce some old concepts, which where pretty easy to maintain,
as well as some new ones in order to improve the performance of the project.

TODO:

- Fix project not properly rendering as a Static Nuxt application (Currenly on SPA mode)
- Calculate stats using Vercel CDN (Lambdas) to prevent client rate limiting
- Separate all Stats logic and fetch into a Component (Repurpose component)
- Extract Octokit into a Hook
- Remove hard-coded rate limit and use @octokit/plugin-throttling
- Extract Repo listing and search functions into a Hook
- Fix repository listing only showing 30 items (with filters), now we tell GitHub API to always max the item capacity to 100 items if possible.
- Implemented repository pagination as an "Infinite Scroll"

TODO:
- Filters
@iksaku iksaku added the enhancement New feature or request label Jan 13, 2021
@iksaku iksaku added this to the v3.1 milestone Jan 13, 2021
@iksaku iksaku self-assigned this Jan 13, 2021
@vercel
Copy link

vercel bot commented Jan 13, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/iksaku/uanl-repo-search/bm24kixah
✅ Preview: https://uanl-repo-search-git-fullstatic.iksaku.vercel.app

@iksaku
Copy link
Owner Author

iksaku commented Jan 13, 2021

📝Changed routes:

/
Screenshot of /
(view full size)

Commit e0e6924 (https://uanl-repo-search-bm24kixah.vercel.app).

- Moved from Set() to Map() for Repo Store
- Making preparations for re-implementing filters
- Separated fearch filters into their own file, will come in handy later
- Line-clamping is such a bless ✨
- Fixed Card URLs opening the API reference, not the HTML repository
@iksaku
Copy link
Owner Author

iksaku commented Jan 15, 2021

TODO:

  • Fix stargazers url opening the API reference, not the HTML one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Rate Limit management F5 reload spends 2 requests available
1 participant