Delete Row Functionality #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the 'remove_current_line' functionality, executable with 'Ctrl + R'
Added the 'Ctrl-R' shortcut to the documentation
Closed
Changed the 'Ctrl-R' action text
Closed
|
Hi Jorge, thank you for your contribution! Unfortunately, the total line of code count for the project increases to 1027 with this PR, which is slightly above the limit (1024). Could you try trimming it down? You may be able to reuse self.delete_char() in your function: I think that deleting a row is equivalent to clearing the row, then pressing "backspace" |
|
I trimmed down my function a little bit, now it has fewer lines and completely deletes the line. |
|
Deleted the file and made the change |
ilai-deutel
approved these changes
Oct 5, 2021
|
@all-contributors please add @imreyesjorge for code |
|
I've put up a pull request to add @imreyesjorge! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using this cool code editor I missed one of my favorite things in VIM, removing entire rows at once.
Hope you find this useful 😄