This repository has been archived by the owner on Sep 5, 2020. It is now read-only.
BoringSSL build system #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have used the build.rs file from Google's Mundane project [1]
slightly simplified it and tweaked for our usage (prefixes).
It's still mostly code copyrighted by Google so I keep the
original notices.
I don't really like the dependency on "goblin" since it pulls in
quite a few transitive dependencies which take a while to compile
but that's better than "bindgen" or "cc" so I might tolerate it.
However, I guess we could opt for calling some ELF/Mach-O utils
directly to read the object files ("nm", anyone?) At least on
UNIX systems which are very likely to have them. Since we require
quite a few tool already (CMake, C/C++ toolchain, Go, Make/Ninja)
I guess it will be okay to add elfutils to the batch and avoid
compiling various unrelated dependencies.
[1]: https://github.com/google/mundane/tree/master/build
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have used the build.rs file from Google's Mundane project, slightly simplified it and tweaked for our usage (prefixes). It's still mostly code copyrighted by Google so I keep the original notices.
I don't really like the dependency on
goblinsince it pulls in quite a few transitive dependencies which take a while to compile but that's better than bindgen or cc so I might tolerate it. However, I guess we could opt for calling some ELF/Mach-O utils directly to read the object files (nm, anyone?) At least on UNIX systems which are very likely to have them. Since we require quite a few tool already (CMake, C/C++ toolchain, Go, Make/Ninja) I guess it will be okay to add elfutils to the batch and avoid compiling various unrelated dependencies.