feat: added connected clusters to the ocm view #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
TomerFi
commented
May 19, 2022
TomerFi
commented
- docs: typo
- feat: added view for local connected k8s clusters
- chore: finalize tree-view for ocm connected clusters
- chore: update views naming convention
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
…w runners Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
TomerFi
force-pushed
the
add-clusters-to-view
branch
from
e5b81f0
to
1944e94
Compare
ilan-pinto
reviewed
May 19, 2022
| @@ -16,7 +16,7 @@ async function sleep(ms: number): Promise<void> { | |||
| // Test cases for the the ocm-vscode-extension.createLocalEnvironment command | |||
| suite('Create local environment command', () => { | |||
| const fakeBuildSuccessMsg = 'this is a fake message'; | |||
| const buildEnvironmentDelayMS = 500; | |||
| const buildEnvironmentDelayMS = 1000; | |||
There was a problem hiding this comment.
GH runners are much slower than my station...
https://github.com/ilan-pinto/ocm-vscode-extension/actions/runs/2350333292
ilan-pinto
reviewed
May 19, 2022
| refresh(): void { | ||
| this.updateK8SConfig(); | ||
| this.configRefreshedEmitter.fire(); | ||
| } |
There was a problem hiding this comment.
this fires an event informing vscode on the data being refreshed.
https://code.visualstudio.com/api/references/vscode-api#EventEmitter%3CT%3E
ilan-pinto
approved these changes
May 19, 2022
|
|
||
| let k8sCoreApi = this.kubeConfig.makeApiClient(k8s.CoreV1Api); | ||
| let namespacesApiResponse = await k8sCoreApi.listNamespace(); | ||
| if (namespacesApiResponse.response.statusCode === 200) { |
There was a problem hiding this comment.
not for the demo, nither does testing.
for now, for error in k8s, an empty list is returned to not f-up the demo.
| listResourcesPromises.push( | ||
| k8sCustomObjApi.listClusterCustomObject(spec.group, ver.name, spec.names.plural) | ||
| .then(crApiResponse => { | ||
| if (crApiResponse.response.statusCode === 200) { |
There was a problem hiding this comment.
not for the demo, nither does testing.
for now, for error in k8s, an empty list is returned to not f-up the demo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.