Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package test data in an ilastik-tests package #2771

Open
k-dominik opened this issue Nov 9, 2023 · 4 comments
Open

package test data in an ilastik-tests package #2771

k-dominik opened this issue Nov 9, 2023 · 4 comments
Labels
conda all things related to conda recipe, packaging enhancement

Comments

@k-dominik
Copy link
Contributor

k-dominik commented Nov 9, 2023

Currently we use the conda build system to build the packages ilastik, ilastik-gpu, ilastik-core. All of these include the test data. Uncompressed our test ilastik folder looks like this:

 92M	tests/test_ilastik
 87M	tests/test_ilastik/data
4.1M	tests/test_ilastik/test_applets
792K	tests/test_ilastik/test_workflows
312K	tests/test_ilastik/widgets
...

clearly, the biggest part is is the data. For environments it gets included twice (ilastik, ilastik-gpu both depend on ilastik-core).

It is not possible to exclude from the conda package with simple means, see discussion here.

One of the suggestions is to build a dedicated package for the test data.

Pros:

  • conda package will be much lighter - faster to download/install

Cons:

  • might make development more awkward.
  • probably a lot of work to adapt our tests to work from that. (We use relative paths from __file__ a lot)
@k-dominik k-dominik added enhancement conda all things related to conda recipe, packaging labels Nov 9, 2023
@k-dominik
Copy link
Contributor Author

I'm gonna 👍 myself, as I had this idea again and already wanted to open a new issue ;D

@k-dominik
Copy link
Contributor Author

k-dominik commented Feb 13, 2024

maybe pooch could be an option to manage these data (thx @FynnBe)

@FynnBe
Copy link
Member

FynnBe commented Feb 13, 2024

At danger of pointing out the obvious.... with pooch you wouldn't need a dedicated package. You could load the same collection from multiple projects/packages.

@k-dominik
Copy link
Contributor Author

yeah thank you Fynn :) I guess the title here does not reflect the sentiment. In the end I want a slimmer ilastik package - dedicated test package was the idea of November...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda all things related to conda recipe, packaging enhancement
Projects
None yet
Development

No branches or pull requests

2 participants